Skip to content

fix(@angular/build) allow component HMR for templates with i18n #30248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025

Conversation

clydin
Copy link
Member

@clydin clydin commented May 5, 2025

When using the development server with the application build system and HMR has been enabled (default), component templates with i18n are now eligible to be hot reloaded. If translations exist within the template, they will also be translated assuming a matching translation is available. Changing the content of an i18n block may result in a missing translation warning/error. The development server continues to only support a single enabled locale.

Closes #29457

@clydin clydin added the target: rc This PR is targeted for the next release-candidate label May 5, 2025
When using the development server with the `application` build system
and HMR has been enabled (default), component templates with i18n are
now eligible to be hot reloaded. If translations exist within the template,
they will also be translated assuming a matching translation is available.
Changing the content of an i18n block may result in a missing translation
warning/error. The development server continues to only support a single
enabled locale.
@clydin clydin force-pushed the hmr/i18n-templates branch from de93523 to c503e2b Compare May 5, 2025 16:44
@clydin clydin marked this pull request as ready for review May 5, 2025 17:05
@clydin clydin requested a review from alan-agius4 May 5, 2025 17:07
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label May 6, 2025
@clydin clydin merged commit 49898e2 into angular:main May 6, 2025
33 checks passed
@clydin
Copy link
Member Author

clydin commented May 6, 2025

The changes were merged into the following branches: main, 20.0.x

@clydin clydin deleted the hmr/i18n-templates branch May 6, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: @angular/build target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking: Support i18n component updates (HMR)
2 participants